fix: ignore unmapped PerformanceIssue events#1852
Open
officialasishkumar wants to merge 1 commit intoChromeDevTools:mainfrom
Open
fix: ignore unmapped PerformanceIssue events#1852officialasishkumar wants to merge 1 commit intoChromeDevTools:mainfrom
officialasishkumar wants to merge 1 commit intoChromeDevTools:mainfrom
Conversation
Lightning00Blade
approved these changes
Apr 16, 2026
Collaborator
Lightning00Blade
left a comment
Lightning00Blade
left a comment
There was a problem hiding this comment.
Thanks for the PR,
I think we can merge after the rebase and update to tests.
And remove the the hard coded bit after we update the version of devtools.
| const inspectorIssue = data.issue; | ||
| // DevTools currently defines this protocol issue code but has no | ||
| // IssuesManager handler for it, so calling into the mapper only warns. | ||
| if (String(inspectorIssue.code) === 'PerformanceIssue') { |
Collaborator
There was a problem hiding this comment.
Note I have landed a change upstream in DevTools - https://crrev.com/c/7761323
to get the supported list so we don't have to hard code this bit.
Author
There was a problem hiding this comment.
Rebased onto latest main and updated the regression test for the current page issue event path. Kept the guard isolated until the DevTools bundle with the supported-list change is pulled in here.
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
officialasishkumar
force-pushed
the
fix/performance-issue-warning
branch
from
7bbfcee to
9808763
Compare
Lightning00Blade
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PerformanceIssueevents before passing them to the DevTools IssuesManager mapper, which currently has no handler for that issue codePerformanceIssueis ignored without collecting an issue or writing a console warningFixes #1850
Testing
npm run buildnpm run test:no-build -- tests/PageCollector.test.tsnpm run check-format